Apply 'trim_scale' function to results of aggregation to improve compatibility with .NET decimal #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For expressions as columns we cast to decimal first because there is a chance it should be done because there is internal cast to decimal and this is the reason that result type of column is decimal, For simple column expressions we probably don't need cast, just trim
renames and summaries, also fixed wrong logic of property and its use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #435.
PostgreSQL 13+ has built-in function that trims unnecessary zeros in fractional part of numeric/decimals, we apply it because insignificant zeros can overflow inner array of longs in .NET decimal. It also allows to not guess precision and scale which may cause precision loss.